Repository navigation
MILAB-7194: store picked columns as ids and gates and conditions as column value references - #16
Merged
Merged
Conversation
Contributor
Author
Contributor
Author
… as column value refs
…h frames args() builds args from whatever is configured and argsIssues() says what keeps the block from running, so the app sees the columns the block references while it is still being set up. The metadata values and the sample names are read in the UI, through a frame of each column, so a column of any storage format can be picked from; a column that is gone or cannot be read says why under its picker.
AStaroverov
force-pushed
the
MILAB-7194_column-value-refs
branch
from
November 4, 2026 08:55
d991e5f to
3ce06c6
Compare
Contributor
Author
There was a problem hiding this comment.
This review was skipped because it would exceed your organization's monthly flex usage limit. Raise the limit in billing settings or wait until the next billing period resets limits.
…in the model tests
Contributor
Author
…t a dataset A block made from a template has its gates and conditions but no dataset, so its picks were never checked against the column and never shown as not available.
|
Automatic reviews are disabled for this repository. Configure in Code Review Settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The block stores the columns it picks as result-pool column ids and the gates and conditions it picks as column value references of the gate and condition columns, so the metadata block knows which of its values this block uses and a missing pick is explained in place. Behaviour is unchanged otherwise: every check that disables the run stays.
ColumnsCollection(["result_pool"])/deriveColumnOptions.PlDatasetSelectorstill speaksPlRef, so the stored ids are converted for it and back.gateOrder,inputGateandexcludedConditionsareColumnValueIds. The ranks the workflow receives are keyed by the same ids.createColumnValueOptionsfor every metadata column on offer, and the settings panel reads them withreadColumnValueOptions. All offered columns are read up front, so a pick writes the value snapshot and seeds the gate order in the same click; no watcher writes block data. The run statistics take the sample names from the model (deriveAxisValuesLabels).gateValuesandconditionValuesare kept asColumnValueId[], so the checks against them stay: a gate column with no values, a gate or an input the gate column does not carry, and every condition excluded still disable the run. The unsorted input is offered from the snapshot, as on main. A pick missing from the column shows as not available, with a tooltip naming the block that was to provide it.argsIssuesreports every check that disables the run; the args lambda no longer throws.isGlobalPObjectId), values asColumnValueIds. Templates made for the earlier kind cannot be applied.Ver_2026_10_21converts the stored dataset and subset refs to ids and clears the anchored condition, gate and sort-fraction columns with the values picked in them and their snapshots. Major bump.json.decoded where a ref is needed, metadata columns come through the bundle by id, picked values are unwrapped withcolumnValue.valueOfand passed to the software as text.PlMaskIcon24replaced byPlIcon24.@milaboratories/helpers1.14.6, which that SDK requires.Checked: forced build 12/12, kind tests 44, model tests 37, software tests 250. Not run: a run on a live backend.


Confidence Score: 5/5
The PR appears safe to merge; no new actionable defect was established.Summary
The PR stores picked columns as result-pool IDs and picked values as column value IDs. The workflow unwraps those values before passing them to the computation.
Important touched types:
ColumnUniversalId: identifies a column. Stored dataset, subset, and metadata picks now use result-pool IDs.ColumnValueId: identifies a value and the column it came from. Gate order, input, exclusions, and snapshots now use these IDs.BlockData: holds saved settings and view state. Its picks use the new IDs.BlockArgs: holds workflow inputs. Column fields can be absent while setup is incomplete; gate ranks are keyed by value IDs.ColumnValueOptionsModel: tells the UI where to read a column’s values. The model now supplies one for every offered metadata column and saved gate or condition pick.ColumnValueOptionsState: tracks whether a UI value read is loading, absent, complete, or failed.AbundancePick: pairs the saved dataset and optional subset IDs for conversion to and from the dataset picker.No build, tests, or browser checks were run during this review.
Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR A[Dataset picker] --> B[Saved column IDs] C[Metadata value sources] --> D[UI reads value options] D --> E[Saved column value IDs] B --> F[BlockArgs] E --> F F --> G[Workflow resolves columns] G --> H[Workflow unwraps picked values] H --> I[Sort-seq computation]Reviews (4) · Last reviewed commit: "MILAB-7194: keep in the migration only t..." · Reviewed by Greptile